]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
Revert "main: Only restore key focus on pop when modal actor is still focused"
authorJonas Dreßler <verdre@v0yd.nl>
Thu, 7 Mar 2024 22:07:23 +0000 (23:07 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Fri, 8 Mar 2024 19:45:20 +0000 (19:45 +0000)
This one caused a regression and now keys appear to get stuck while raising
the screenShield, so revert it. Hopefully we can fix the original problem in
a better way next cycle by tracking key focus changes internally in
ClutterGrab.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7446

This reverts commit 4d544d7b5614cd33bf60c1b610f8b81546955fbb.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3231>

js/ui/main.js

index eeb83c9b19e7339371665f2626ba69d4424ffa3f..9f1697df2b56e5849e94088ec167a4385a8df878 100644 (file)
@@ -742,8 +742,7 @@ export function popModal(grab) {
         if (record.prevFocus)
             record.prevFocus.disconnect(record.prevFocusDestroyId);
         actionMode = record.actionMode;
-        if (global.stage.key_focus === record.actor)
-            global.stage.set_key_focus(record.prevFocus);
+        global.stage.set_key_focus(record.prevFocus);
     } else {
         // If we have:
         //     global.stage.set_focus(a);